Просмотр исходного кода

Merge pull request #1135 from azamat-sharapov/currency-symbol

Currency symbol
Evan You 11 лет назад
Родитель
Сommit
cc977372c7
3 измененных файлов с 4 добавлено и 2 удалено
  1. 1 1
      CONTRIBUTING.md
  2. 1 1
      src/filters/index.js
  3. 2 0
      test/unit/specs/filters/filters_spec.js

+ 1 - 1
CONTRIBUTING.md

@@ -81,4 +81,4 @@ The default task (by simply running `grunt`) will do the following: lint -> buil
 
 
 The unit tests are written with Jasmine and run with Karma. The e2e tests are written for and run with CasperJS.
 The unit tests are written with Jasmine and run with Karma. The e2e tests are written for and run with CasperJS.
 
 
-Note that the unit tests will automatically be run in Chrome, Firefox and Safari. If you are not on a Mac, or don't have one of the browsers installed on your system, you can modify the [karma config in gruntfile.js](https://github.com/yyx990803/vue/blob/dev/gruntfile.js#L42) to only run Karma tests in browsers that are available on your system. Just make sure don’t check in the gruntfile changes for the commit.
+Note that the unit tests will automatically be run in Chrome, Firefox and Safari. If you are not on a Mac, or don't have one of the browsers installed on your system, you can modify the [karma config in gruntfile.js](https://github.com/yyx990803/vue/blob/dev/gruntfile.js#L38) to only run Karma tests in browsers that are available on your system. Just make sure don’t check in the gruntfile changes for the commit.

+ 1 - 1
src/filters/index.js

@@ -61,7 +61,7 @@ var digitsRE = /(\d{3})(?=\d)/g
 exports.currency = function (value, currency) {
 exports.currency = function (value, currency) {
   value = parseFloat(value)
   value = parseFloat(value)
   if (!isFinite(value) || (!value && value !== 0)) return ''
   if (!isFinite(value) || (!value && value !== 0)) return ''
-  currency = currency || '$'
+  currency = currency != null ? currency : '$'
   var stringified = Math.abs(value).toFixed(2)
   var stringified = Math.abs(value).toFixed(2)
   var _int = stringified.slice(0, -3)
   var _int = stringified.slice(0, -3)
   var i = _int.length % 3
   var i = _int.length % 3

+ 2 - 0
test/unit/specs/filters/filters_spec.js

@@ -66,6 +66,8 @@ describe('Filters', function () {
     expect(filter(0.76)).toBe('$0.76')
     expect(filter(0.76)).toBe('$0.76')
     // sign arg
     // sign arg
     expect(filter(2134, '@')).toBe('@2,134.00')
     expect(filter(2134, '@')).toBe('@2,134.00')
+    // no symbol
+    expect(filter(2134, '')).toBe('2,134.00')
     // falsy, infinity and 0
     // falsy, infinity and 0
     expect(filter(0)).toBe('$0.00')
     expect(filter(0)).toBe('$0.00')
     expect(filter(false)).toBe('')
     expect(filter(false)).toBe('')