Przeglądaj źródła

Made the convertAllProperties configuration option false by default

Justin Berger 10 lat temu
rodzic
commit
2e9db42436
2 zmienionych plików z 12 dodań i 1 usunięć
  1. 1 1
      src/config.js
  2. 11 0
      test/unit/specs/observer/observer_spec.js

+ 1 - 1
src/config.js

@@ -36,7 +36,7 @@ module.exports = {
    * use case and environment, this might introduce non-neglible
    * performance penalties.
    */
-  convertAllProperties: true,
+  convertAllProperties: false,
 
   /**
    * Internal flag to indicate the delimiters have been

+ 11 - 0
test/unit/specs/observer/observer_spec.js

@@ -1,6 +1,7 @@
 var Observer = require('../../../../src/observer')
 var Dep = require('../../../../src/observer/dep')
 var _ = require('../../../../src/util')
+var config = require('../../../../src/config')
 
 describe('Observer', function () {
 
@@ -39,6 +40,9 @@ describe('Observer', function () {
   })
 
   it('create on already observed object', function () {
+    var previousConvertAllProperties = config.convertAllProperties
+    config.convertAllProperties = true
+
     // on object
     var obj = {}
     var val = 0
@@ -65,6 +69,8 @@ describe('Observer', function () {
     // should call underlying setter
     obj.a = 10
     expect(val).toBe(10)
+
+    config.convertAllProperties = previousConvertAllProperties
   })
 
   it('create on array', function () {
@@ -112,6 +118,9 @@ describe('Observer', function () {
   })
 
   it('observing object prop change on defined property', function () {
+    var previousConvertAllProperties = config.convertAllProperties
+    config.convertAllProperties = true
+
     var obj = { val: 2 }
     Object.defineProperty(obj, 'a', {
       configurable: true,
@@ -143,6 +152,8 @@ describe('Observer', function () {
     expect(obj.val).toBe(3) // make sure 'setter' was called
     obj.val = 5
     expect(obj.a).toBe(5) // make sure 'getter' was called
+
+    config.convertAllProperties = previousConvertAllProperties
   })
 
   it('observing set/delete', function () {