| 12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154 |
- import {
- type TestElement,
- defineComponent,
- h,
- nextTick,
- nodeOps,
- onMounted,
- onUnmounted,
- render,
- serializeInner,
- triggerEvent,
- } from '@vue/runtime-test'
- import {
- type DebuggerEvent,
- ITERATE_KEY,
- TrackOpTypes,
- TriggerOpTypes,
- type WritableComputedRef,
- computed,
- effect,
- isReadonly,
- reactive,
- ref,
- shallowRef,
- toRaw,
- triggerRef,
- } from '../src'
- import type { ComputedRef, ComputedRefImpl } from '../src/computed'
- import { pauseTracking, resetTracking } from '../src/effect'
- import { ReactiveFlags } from '../src/system'
- describe('reactivity/computed', () => {
- it('should return updated value', () => {
- const value = reactive<{ foo?: number }>({})
- const cValue = computed(() => value.foo)
- expect(cValue.value).toBe(undefined)
- value.foo = 1
- expect(cValue.value).toBe(1)
- })
- it('pass oldValue to computed getter', () => {
- const count = ref(0)
- const oldValue = ref()
- const curValue = computed(pre => {
- oldValue.value = pre
- return count.value
- })
- expect(curValue.value).toBe(0)
- expect(oldValue.value).toBe(undefined)
- count.value++
- expect(curValue.value).toBe(1)
- expect(oldValue.value).toBe(0)
- })
- it('should compute lazily', () => {
- const value = reactive<{ foo?: number }>({})
- const getter = vi.fn(() => value.foo)
- const cValue = computed(getter)
- // lazy
- expect(getter).not.toHaveBeenCalled()
- expect(cValue.value).toBe(undefined)
- expect(getter).toHaveBeenCalledTimes(1)
- // should not compute again
- cValue.value
- expect(getter).toHaveBeenCalledTimes(1)
- // should not compute until needed
- value.foo = 1
- expect(getter).toHaveBeenCalledTimes(1)
- // now it should compute
- expect(cValue.value).toBe(1)
- expect(getter).toHaveBeenCalledTimes(2)
- // should not compute again
- cValue.value
- expect(getter).toHaveBeenCalledTimes(2)
- })
- it('should trigger effect', () => {
- const value = reactive<{ foo?: number }>({})
- const cValue = computed(() => value.foo)
- let dummy
- effect(() => {
- dummy = cValue.value
- })
- expect(dummy).toBe(undefined)
- value.foo = 1
- expect(dummy).toBe(1)
- })
- it('should work when chained', () => {
- const value = reactive({ foo: 0 })
- const c1 = computed(() => value.foo)
- const c2 = computed(() => c1.value + 1)
- expect(c2.value).toBe(1)
- expect(c1.value).toBe(0)
- value.foo++
- expect(c2.value).toBe(2)
- expect(c1.value).toBe(1)
- })
- it('should trigger effect when chained', () => {
- const value = reactive({ foo: 0 })
- const getter1 = vi.fn(() => value.foo)
- const getter2 = vi.fn(() => {
- return c1.value + 1
- })
- const c1 = computed(getter1)
- const c2 = computed(getter2)
- let dummy
- effect(() => {
- dummy = c2.value
- })
- expect(dummy).toBe(1)
- expect(getter1).toHaveBeenCalledTimes(1)
- expect(getter2).toHaveBeenCalledTimes(1)
- value.foo++
- expect(dummy).toBe(2)
- // should not result in duplicate calls
- expect(getter1).toHaveBeenCalledTimes(2)
- expect(getter2).toHaveBeenCalledTimes(2)
- })
- it('should trigger effect when chained (mixed invocations)', () => {
- const value = reactive({ foo: 0 })
- const getter1 = vi.fn(() => value.foo)
- const getter2 = vi.fn(() => {
- return c1.value + 1
- })
- const c1 = computed(getter1)
- const c2 = computed(getter2)
- let dummy
- effect(() => {
- dummy = c1.value + c2.value
- })
- expect(dummy).toBe(1)
- expect(getter1).toHaveBeenCalledTimes(1)
- expect(getter2).toHaveBeenCalledTimes(1)
- value.foo++
- expect(dummy).toBe(3)
- // should not result in duplicate calls
- expect(getter1).toHaveBeenCalledTimes(2)
- expect(getter2).toHaveBeenCalledTimes(2)
- })
- it('should support setter', () => {
- const n = ref(1)
- const plusOne = computed({
- get: () => n.value + 1,
- set: val => {
- n.value = val - 1
- },
- })
- expect(plusOne.value).toBe(2)
- n.value++
- expect(plusOne.value).toBe(3)
- plusOne.value = 0
- expect(n.value).toBe(-1)
- })
- it('should trigger effect w/ setter', () => {
- const n = ref(1)
- const plusOne = computed({
- get: () => n.value + 1,
- set: val => {
- n.value = val - 1
- },
- })
- let dummy
- effect(() => {
- dummy = n.value
- })
- expect(dummy).toBe(1)
- plusOne.value = 0
- expect(dummy).toBe(-1)
- })
- // #5720
- it('should invalidate before non-computed effects', () => {
- let plusOneValues: number[] = []
- const n = ref(0)
- const plusOne = computed(() => n.value + 1)
- effect(() => {
- n.value
- plusOneValues.push(plusOne.value)
- })
- // access plusOne, causing it to be non-dirty
- plusOne.value
- // mutate n
- n.value++
- // on the 2nd run, plusOne.value should have already updated.
- expect(plusOneValues).toMatchObject([1, 2])
- })
- it('should warn if trying to set a readonly computed', () => {
- const n = ref(1)
- const plusOne = computed(() => n.value + 1)
- ;(plusOne as WritableComputedRef<number>).value++ // Type cast to prevent TS from preventing the error
- expect(
- 'Write operation failed: computed value is readonly',
- ).toHaveBeenWarnedLast()
- })
- it('should be readonly', () => {
- let a = { a: 1 }
- const x = computed(() => a)
- expect(isReadonly(x)).toBe(true)
- expect(isReadonly(x.value)).toBe(false)
- expect(isReadonly(x.value.a)).toBe(false)
- const z = computed<typeof a>({
- get() {
- return a
- },
- set(v) {
- a = v
- },
- })
- expect(isReadonly(z)).toBe(false)
- expect(isReadonly(z.value.a)).toBe(false)
- })
- it('debug: onTrack', () => {
- let events: DebuggerEvent[] = []
- const onTrack = vi.fn((e: DebuggerEvent) => {
- events.push(e)
- })
- const obj = reactive({ foo: 1, bar: 2 })
- const c = computed(() => (obj.foo, 'bar' in obj, Object.keys(obj)), {
- onTrack,
- })
- expect(c.value).toEqual(['foo', 'bar'])
- expect(onTrack).toHaveBeenCalledTimes(3)
- expect(events).toEqual([
- {
- effect: c,
- target: toRaw(obj),
- type: TrackOpTypes.GET,
- key: 'foo',
- },
- {
- effect: c,
- target: toRaw(obj),
- type: TrackOpTypes.HAS,
- key: 'bar',
- },
- {
- effect: c,
- target: toRaw(obj),
- type: TrackOpTypes.ITERATE,
- key: ITERATE_KEY,
- },
- ])
- })
- it('debug: onTrigger (reactive)', () => {
- let events: DebuggerEvent[] = []
- const onTrigger = vi.fn((e: DebuggerEvent) => {
- events.push(e)
- })
- const obj = reactive<{ foo?: number }>({ foo: 1 })
- const c = computed(() => obj.foo, { onTrigger })
- // computed won't track until it has a subscriber
- effect(() => c.value)
- obj.foo!++
- expect(c.value).toBe(2)
- expect(onTrigger).toHaveBeenCalledTimes(1)
- expect(events[0]).toEqual({
- effect: c,
- target: toRaw(obj),
- type: TriggerOpTypes.SET,
- key: 'foo',
- oldValue: 1,
- newValue: 2,
- })
- delete obj.foo
- expect(c.value).toBeUndefined()
- expect(onTrigger).toHaveBeenCalledTimes(2)
- expect(events[1]).toEqual({
- effect: c,
- target: toRaw(obj),
- type: TriggerOpTypes.DELETE,
- key: 'foo',
- oldValue: 2,
- })
- })
- // https://github.com/vuejs/core/pull/5912#issuecomment-1497596875
- it('should query deps dirty sequentially', () => {
- const cSpy = vi.fn()
- const a = ref<null | { v: number }>({
- v: 1,
- })
- const b = computed(() => {
- return a.value
- })
- const c = computed(() => {
- cSpy()
- return b.value?.v
- })
- const d = computed(() => {
- if (b.value) {
- return c.value
- }
- return 0
- })
- d.value
- a.value!.v = 2
- a.value = null
- d.value
- expect(cSpy).toHaveBeenCalledTimes(1)
- })
- // https://github.com/vuejs/core/pull/5912#issuecomment-1738257692
- it('chained computed dirty reallocation after querying dirty', () => {
- let _msg: string | undefined
- const items = ref<number[]>()
- const isLoaded = computed(() => {
- return !!items.value
- })
- const msg = computed(() => {
- if (isLoaded.value) {
- return 'The items are loaded'
- } else {
- return 'The items are not loaded'
- }
- })
- effect(() => {
- _msg = msg.value
- })
- items.value = [1, 2, 3]
- items.value = [1, 2, 3]
- items.value = undefined
- expect(_msg).toBe('The items are not loaded')
- })
- it('chained computed dirty reallocation after trigger computed getter', () => {
- let _msg: string | undefined
- const items = ref<number[]>()
- const isLoaded = computed(() => {
- return !!items.value
- })
- const msg = computed(() => {
- if (isLoaded.value) {
- return 'The items are loaded'
- } else {
- return 'The items are not loaded'
- }
- })
- _msg = msg.value
- items.value = [1, 2, 3]
- isLoaded.value // <- trigger computed getter
- _msg = msg.value
- items.value = undefined
- _msg = msg.value
- expect(_msg).toBe('The items are not loaded')
- })
- // https://github.com/vuejs/core/pull/5912#issuecomment-1739159832
- it('deps order should be consistent with the last time get value', () => {
- const cSpy = vi.fn()
- const a = ref(0)
- const b = computed(() => {
- return a.value % 3 !== 0
- }) as unknown as ComputedRefImpl
- const c = computed(() => {
- cSpy()
- if (a.value % 3 === 2) {
- return 'expensive'
- }
- return 'cheap'
- }) as unknown as ComputedRefImpl
- const d = computed(() => {
- return a.value % 3 === 2
- }) as unknown as ComputedRefImpl
- const e = computed(() => {
- if (b.value) {
- if (d.value) {
- return 'Avoiding expensive calculation'
- }
- }
- return c.value
- }) as unknown as ComputedRefImpl
- e.value
- a.value++
- e.value
- expect(e.deps!.dep).toBe(b)
- expect(e.deps!.nextDep!.dep).toBe(d)
- expect(e.deps!.nextDep!.nextDep!.dep).toBe(c)
- expect(cSpy).toHaveBeenCalledTimes(2)
- a.value++
- e.value
- expect(cSpy).toHaveBeenCalledTimes(2)
- })
- it('should trigger by the second computed that maybe dirty', () => {
- const cSpy = vi.fn()
- const src1 = ref(0)
- const src2 = ref(0)
- const c1 = computed(() => src1.value)
- const c2 = computed(() => (src1.value % 2) + src2.value)
- const c3 = computed(() => {
- cSpy()
- c1.value
- c2.value
- })
- c3.value
- src1.value = 2
- c3.value
- expect(cSpy).toHaveBeenCalledTimes(2)
- src2.value = 1
- c3.value
- expect(cSpy).toHaveBeenCalledTimes(3)
- })
- it('should trigger the second effect', () => {
- const fnSpy = vi.fn()
- const v = ref(1)
- const c = computed(() => v.value)
- effect(() => {
- c.value
- })
- effect(() => {
- c.value
- fnSpy()
- })
- expect(fnSpy).toBeCalledTimes(1)
- v.value = 2
- expect(fnSpy).toBeCalledTimes(2)
- })
- it('should chained recursive effects clear dirty after trigger', () => {
- const v = ref(1)
- const c1 = computed(() => v.value) as unknown as ComputedRefImpl
- const c2 = computed(() => c1.value) as unknown as ComputedRefImpl
- c2.value
- expect(c1.flags & (ReactiveFlags.Dirty | ReactiveFlags.Pending)).toBe(0)
- expect(c2.flags & (ReactiveFlags.Dirty | ReactiveFlags.Pending)).toBe(0)
- })
- it('should chained computeds dirtyLevel update with first computed effect', () => {
- const v = ref(0)
- const c1 = computed(() => {
- if (v.value === 0) {
- v.value = 1
- }
- return v.value
- })
- const c2 = computed(() => c1.value)
- const c3 = computed(() => c2.value)
- c3.value
- // expect(COMPUTED_SIDE_EFFECT_WARN).toHaveBeenWarned()
- })
- it('should work when chained(ref+computed)', () => {
- const v = ref(0)
- const c1 = computed(() => {
- if (v.value === 0) {
- v.value = 1
- }
- return 'foo'
- })
- const c2 = computed(() => v.value + c1.value)
- expect(c2.value).toBe('0foo')
- expect(c2.value).toBe('1foo')
- // expect(COMPUTED_SIDE_EFFECT_WARN).toHaveBeenWarned()
- })
- it('should trigger effect even computed already dirty', () => {
- const fnSpy = vi.fn()
- const v = ref(0)
- const c1 = computed(() => {
- if (v.value === 0) {
- v.value = 1
- }
- return 'foo'
- })
- const c2 = computed(() => v.value + c1.value)
- effect(() => {
- fnSpy(c2.value)
- })
- expect(fnSpy).toBeCalledTimes(1)
- expect(fnSpy.mock.calls).toMatchObject([['0foo']])
- expect(v.value).toBe(1)
- v.value = 2
- expect(fnSpy).toBeCalledTimes(2)
- expect(fnSpy.mock.calls).toMatchObject([['0foo'], ['2foo']])
- expect(v.value).toBe(2)
- // expect(COMPUTED_SIDE_EFFECT_WARN).toHaveBeenWarned()
- })
- // #10185
- it('should not override queried MaybeDirty result', () => {
- class Item {
- v = ref(0)
- }
- const v1 = shallowRef()
- const v2 = ref(false)
- const c1 = computed(() => {
- let c = v1.value
- if (!v1.value) {
- c = new Item()
- v1.value = c
- }
- return c.v.value
- })
- const c2 = computed(() => {
- if (!v2.value) return 'no'
- return c1.value ? 'yes' : 'no'
- })
- const c3 = computed(() => c2.value)
- c3.value
- v2.value = true
- c3.value
- v1.value.v.value = 999
- expect(c3.value).toBe('yes')
- // expect(COMPUTED_SIDE_EFFECT_WARN).toHaveBeenWarned()
- })
- it('should be not dirty after deps mutate (mutate deps in computed)', async () => {
- const state = reactive<any>({})
- const consumer = computed(() => {
- if (!('a' in state)) state.a = 1
- return state.a
- })
- const Comp = {
- setup: () => {
- nextTick().then(() => {
- state.a = 2
- })
- return () => consumer.value
- },
- }
- const root = nodeOps.createElement('div')
- render(h(Comp), root)
- await nextTick()
- await nextTick()
- expect(serializeInner(root)).toBe(`2`)
- // expect(COMPUTED_SIDE_EFFECT_WARN).toHaveBeenWarned()
- })
- it('should not trigger effect scheduler by recursive computed effect', async () => {
- const v = ref('Hello')
- const c = computed(() => {
- v.value += ' World'
- return v.value
- })
- const Comp = {
- setup: () => {
- return () => c.value
- },
- }
- const root = nodeOps.createElement('div')
- render(h(Comp), root)
- await nextTick()
- expect(serializeInner(root)).toBe('Hello World')
- v.value += ' World'
- await nextTick()
- expect(serializeInner(root)).toBe('Hello World World World World')
- // expect(COMPUTED_SIDE_EFFECT_WARN).toHaveBeenWarned()
- })
- test('should not trigger if value did not change', () => {
- const src = ref(0)
- const c = computed(() => src.value % 2)
- const spy = vi.fn()
- effect(() => {
- spy(c.value)
- })
- expect(spy).toHaveBeenCalledTimes(1)
- src.value = 2
- // should not trigger
- expect(spy).toHaveBeenCalledTimes(1)
- src.value = 3
- src.value = 5
- // should trigger because latest value changes
- expect(spy).toHaveBeenCalledTimes(2)
- })
- test('chained computed trigger', () => {
- const effectSpy = vi.fn()
- const c1Spy = vi.fn()
- const c2Spy = vi.fn()
- const src = ref(0)
- const c1 = computed(() => {
- c1Spy()
- return src.value % 2
- })
- const c2 = computed(() => {
- c2Spy()
- return c1.value + 1
- })
- effect(() => {
- effectSpy(c2.value)
- })
- expect(c1Spy).toHaveBeenCalledTimes(1)
- expect(c2Spy).toHaveBeenCalledTimes(1)
- expect(effectSpy).toHaveBeenCalledTimes(1)
- src.value = 1
- expect(c1Spy).toHaveBeenCalledTimes(2)
- expect(c2Spy).toHaveBeenCalledTimes(2)
- expect(effectSpy).toHaveBeenCalledTimes(2)
- })
- test('chained computed avoid re-compute', () => {
- const effectSpy = vi.fn()
- const c1Spy = vi.fn()
- const c2Spy = vi.fn()
- const src = ref(0)
- const c1 = computed(() => {
- c1Spy()
- return src.value % 2
- })
- const c2 = computed(() => {
- c2Spy()
- return c1.value + 1
- })
- effect(() => {
- effectSpy(c2.value)
- })
- expect(effectSpy).toHaveBeenCalledTimes(1)
- src.value = 2
- src.value = 4
- src.value = 6
- expect(c1Spy).toHaveBeenCalledTimes(4)
- // c2 should not have to re-compute because c1 did not change.
- expect(c2Spy).toHaveBeenCalledTimes(1)
- // effect should not trigger because c2 did not change.
- expect(effectSpy).toHaveBeenCalledTimes(1)
- })
- test('chained computed value invalidation', () => {
- const effectSpy = vi.fn()
- const c1Spy = vi.fn()
- const c2Spy = vi.fn()
- const src = ref(0)
- const c1 = computed(() => {
- c1Spy()
- return src.value % 2
- })
- const c2 = computed(() => {
- c2Spy()
- return c1.value + 1
- })
- effect(() => {
- effectSpy(c2.value)
- })
- expect(effectSpy).toHaveBeenCalledTimes(1)
- expect(effectSpy).toHaveBeenCalledWith(1)
- expect(c2.value).toBe(1)
- expect(c1Spy).toHaveBeenCalledTimes(1)
- expect(c2Spy).toHaveBeenCalledTimes(1)
- src.value = 1
- // value should be available sync
- expect(c2.value).toBe(2)
- expect(c2Spy).toHaveBeenCalledTimes(2)
- })
- test('sync access of invalidated chained computed should not prevent final effect from running', () => {
- const effectSpy = vi.fn()
- const c1Spy = vi.fn()
- const c2Spy = vi.fn()
- const src = ref(0)
- const c1 = computed(() => {
- c1Spy()
- return src.value % 2
- })
- const c2 = computed(() => {
- c2Spy()
- return c1.value + 1
- })
- effect(() => {
- effectSpy(c2.value)
- })
- expect(effectSpy).toHaveBeenCalledTimes(1)
- src.value = 1
- // sync access c2
- c2.value
- expect(effectSpy).toHaveBeenCalledTimes(2)
- })
- it('computed should force track in untracked zone', () => {
- const n = ref(0)
- const spy1 = vi.fn()
- const spy2 = vi.fn()
- let c: ComputedRef
- effect(() => {
- spy1()
- pauseTracking()
- n.value
- c = computed(() => n.value + 1)
- // access computed now to force refresh
- c.value
- effect(() => spy2(c.value))
- n.value
- resetTracking()
- })
- expect(spy1).toHaveBeenCalledTimes(1)
- expect(spy2).toHaveBeenCalledTimes(1)
- n.value++
- // outer effect should not trigger
- expect(spy1).toHaveBeenCalledTimes(1)
- // inner effect should trigger
- expect(spy2).toHaveBeenCalledTimes(2)
- })
- // not recommended behavior, but needed for backwards compatibility
- // used in VueUse asyncComputed
- it('computed side effect should be able trigger', () => {
- const a = ref(false)
- const b = ref(false)
- const c = computed(() => {
- a.value = true
- return b.value
- })
- effect(() => {
- if (a.value) {
- b.value = true
- }
- })
- expect(b.value).toBe(false)
- // accessing c triggers change
- c.value
- expect(b.value).toBe(true)
- expect(c.value).toBe(true)
- })
- it('chained computed should work when accessed before having subs', () => {
- const n = ref(0)
- const c = computed(() => n.value)
- const d = computed(() => c.value + 1)
- const spy = vi.fn()
- // access
- d.value
- let dummy
- effect(() => {
- spy()
- dummy = d.value
- })
- expect(spy).toHaveBeenCalledTimes(1)
- expect(dummy).toBe(1)
- n.value++
- expect(spy).toHaveBeenCalledTimes(2)
- expect(dummy).toBe(2)
- })
- // #10236
- it('chained computed should still refresh after owner component unmount', async () => {
- const a = ref(0)
- const spy = vi.fn()
- const Child = {
- setup() {
- const b = computed(() => a.value + 1)
- const c = computed(() => b.value + 1)
- // access
- c.value
- onUnmounted(() => spy(c.value))
- return () => {}
- },
- }
- const show = ref(true)
- const Parent = {
- setup() {
- return () => (show.value ? h(Child) : null)
- },
- }
- render(h(Parent), nodeOps.createElement('div'))
- a.value++
- show.value = false
- await nextTick()
- expect(spy).toHaveBeenCalledWith(3)
- })
- // case: radix-vue `useForwardExpose` sets a template ref during mount,
- // and checks for the element's closest form element in a computed.
- // the computed is expected to only evaluate after mount.
- it('computed deps should only be refreshed when the subscribing effect is run, not when scheduled', async () => {
- const calls: string[] = []
- const a = ref(0)
- const b = computed(() => {
- calls.push('b eval')
- return a.value + 1
- })
- const App = {
- setup() {
- onMounted(() => {
- calls.push('mounted')
- })
- return () =>
- h(
- 'div',
- {
- ref: () => (a.value = 1),
- },
- b.value,
- )
- },
- }
- render(h(App), nodeOps.createElement('div'))
- await nextTick()
- expect(calls).toMatchObject(['b eval', 'mounted', 'b eval'])
- })
- it('should chained computeds keep reactivity when computed effect happens', async () => {
- const v = ref('Hello')
- const c = computed(() => {
- v.value += ' World'
- return v.value
- })
- const d = computed(() => c.value)
- const e = computed(() => d.value)
- const Comp = {
- setup: () => {
- return () => d.value + ' | ' + e.value
- },
- }
- const root = nodeOps.createElement('div')
- render(h(Comp), root)
- await nextTick()
- expect(serializeInner(root)).toBe('Hello World | Hello World')
- v.value += ' World'
- await nextTick()
- expect(serializeInner(root)).toBe(
- 'Hello World World World World | Hello World World World World',
- )
- })
- it('should keep dirty level when side effect computed value changed', () => {
- const v = ref(0)
- const c = computed(() => {
- v.value += 1
- return v.value
- })
- const d = computed(() => {
- return { d: c.value }
- })
- const Comp = {
- setup: () => {
- return () => {
- return [d.value.d, d.value.d]
- }
- },
- }
- const root = nodeOps.createElement('div')
- render(h(Comp), root)
- expect(d.value.d).toBe(1)
- expect(serializeInner(root)).toBe('11')
- })
- it('should be recomputed without being affected by side effects', () => {
- const v = ref(0)
- const c1 = computed(() => {
- v.value = 1
- return 0
- })
- const c2 = computed(() => {
- return v.value + ',' + c1.value
- })
- expect(c2.value).toBe('0,0')
- v.value = 1
- expect(c2.value).toBe('1,0')
- // expect(COMPUTED_SIDE_EFFECT_WARN).toHaveBeenWarned()
- })
- it('debug: onTrigger (ref)', () => {
- let events: DebuggerEvent[] = []
- const onTrigger = vi.fn((e: DebuggerEvent) => {
- events.push(e)
- })
- const obj = ref(1)
- const c = computed(() => obj.value, { onTrigger })
- // computed won't track until it has a subscriber
- effect(() => c.value)
- obj.value++
- expect(c.value).toBe(2)
- expect(onTrigger).toHaveBeenCalledTimes(1)
- expect(events[0]).toEqual({
- effect: c,
- target: toRaw(obj),
- type: TriggerOpTypes.SET,
- key: 'value',
- oldValue: 1,
- newValue: 2,
- })
- })
- // #11797
- test('should prevent endless recursion in self-referencing computed getters', async () => {
- const Comp = defineComponent({
- data() {
- return {
- counter: 0,
- }
- },
- computed: {
- message(): string {
- if (this.counter === 0) {
- this.counter++
- return this.message
- } else {
- return `Step ${this.counter}`
- }
- },
- },
- render() {
- return [
- h(
- 'button',
- {
- onClick: () => {
- this.counter++
- },
- },
- 'Step',
- ),
- h('p', this.message),
- ]
- },
- })
- const root = nodeOps.createElement('div')
- render(h(Comp), root)
- expect(serializeInner(root)).toBe(`<button>Step</button><p>Step 1</p>`)
- triggerEvent(root.children[1] as TestElement, 'click')
- await nextTick()
- expect(serializeInner(root)).toBe(`<button>Step</button><p>Step 2</p>`)
- })
- test('manual trigger computed', () => {
- const cValue = computed(() => 1)
- triggerRef(cValue)
- expect(cValue.value).toBe(1)
- })
- test('should not recompute if computed does not track reactive data', async () => {
- const spy = vi.fn()
- const c1 = computed(() => spy())
- c1.value
- ref(0).value++ // update globalVersion
- c1.value
- expect(spy).toBeCalledTimes(1)
- })
- test('computed should remain live after losing all subscribers', () => {
- const state = reactive({ a: 1 })
- const p = computed(() => state.a + 1)
- const { effect: e } = effect(() => p.value)
- e.stop()
- expect(p.value).toBe(2)
- state.a++
- expect(p.value).toBe(3)
- })
- // #11995
- test('computed dep cleanup should not cause property dep to be deleted', () => {
- const toggle = ref(true)
- const state = reactive({ a: 1 })
- const p = computed(() => {
- return toggle.value ? state.a : 111
- })
- const pp = computed(() => state.a)
- effect(() => p.value)
- expect(pp.value).toBe(1)
- toggle.value = false
- state.a++
- expect(pp.value).toBe(2)
- })
- // #12020
- test('computed value updates correctly after dep cleanup', () => {
- const obj = reactive({ foo: 1, flag: 1 })
- const c1 = computed(() => obj.foo)
- let foo
- effect(() => {
- foo = obj.flag ? (obj.foo, c1.value) : 0
- })
- expect(foo).toBe(1)
- obj.flag = 0
- expect(foo).toBe(0)
- obj.foo = 2
- obj.flag = 1
- expect(foo).toBe(2)
- })
- // #11928
- test('should not lead to exponential perf cost with deeply chained computed', () => {
- const start = {
- prop1: shallowRef(1),
- prop2: shallowRef(2),
- prop3: shallowRef(3),
- prop4: shallowRef(4),
- }
- let layer = start
- const LAYERS = 1000
- for (let i = LAYERS; i > 0; i--) {
- const m = layer
- const s = {
- prop1: computed(() => m.prop2.value),
- prop2: computed(() => m.prop1.value - m.prop3.value),
- prop3: computed(() => m.prop2.value + m.prop4.value),
- prop4: computed(() => m.prop3.value),
- }
- effect(() => s.prop1.value)
- effect(() => s.prop2.value)
- effect(() => s.prop3.value)
- effect(() => s.prop4.value)
- s.prop1.value
- s.prop2.value
- s.prop3.value
- s.prop4.value
- layer = s
- }
- const t = performance.now()
- start.prop1.value = 4
- start.prop2.value = 3
- start.prop3.value = 2
- start.prop4.value = 1
- expect(performance.now() - t).toBeLessThan(process.env.CI ? 100 : 30)
- const end = layer
- expect([
- end.prop1.value,
- end.prop2.value,
- end.prop3.value,
- end.prop4.value,
- ]).toMatchObject([-2, -4, 2, 3])
- })
- test('performance when removing dependencies from deeply nested computeds', () => {
- const base = ref(1)
- const trigger = ref(true)
- const computeds: ComputedRef<number>[] = []
- const LAYERS = 30
- for (let i = 0; i < LAYERS; i++) {
- const earlier = [...computeds]
- computeds.push(
- computed(() => {
- return base.value + earlier.reduce((sum, c) => sum + c.value, 0)
- }),
- )
- }
- const tail = computed(() =>
- trigger.value ? computeds[computeds.length - 1].value : 0,
- )
- const t0 = performance.now()
- expect(tail.value).toBe(2 ** (LAYERS - 1))
- const t1 = performance.now()
- expect(t1 - t0).toBeLessThan(process.env.CI ? 100 : 30)
- trigger.value = false
- expect(tail.value).toBe(0)
- const t2 = performance.now()
- expect(t2 - t1).toBeLessThan(process.env.CI ? 100 : 30)
- })
- })
|