Selaa lähdekoodia

refactor: move writable check out of computed setter (#112)

扩散性百万甜面包 6 vuotta sitten
vanhempi
commit
caa9297da6
1 muutettua tiedostoa jossa 5 lisäystä ja 7 poistoa
  1. 5 7
      packages/reactivity/src/computed.ts

+ 5 - 7
packages/reactivity/src/computed.ts

@@ -28,7 +28,9 @@ export function computed<T>(
     ? (getterOrOptions as (() => T))
     : (getterOrOptions as WritableComputedOptions<T>).get
   const setter = isReadonly
-    ? null
+    ? () => {
+        // TODO warn attempting to mutate readonly computed value
+      }
     : (getterOrOptions as WritableComputedOptions<T>).set
 
   let dirty: boolean = true
@@ -57,12 +59,8 @@ export function computed<T>(
       trackChildRun(runner)
       return value
     },
-    set value(newValue) {
-      if (setter) {
-        setter(newValue)
-      } else {
-        // TODO warn attempting to mutate readonly computed value
-      }
+    set value(newValue: T) {
+      setter(newValue)
     }
   }
 }