浏览代码

fix(dx): warn against reserved keys as prop name

close #10281
Evan You 2 年之前
父节点
当前提交
77a804b1d0
共有 2 个文件被更改,包括 20 次插入1 次删除
  1. 19 0
      packages/runtime-core/__tests__/componentProps.spec.ts
  2. 1 1
      packages/runtime-core/src/componentProps.ts

+ 19 - 0
packages/runtime-core/__tests__/componentProps.spec.ts

@@ -729,4 +729,23 @@ describe('component props', () => {
 
     expect(Object.keys(props.msg).length).toBe(1)
   })
+
+  test('should warn against reserved prop names', () => {
+    const Comp = defineComponent({
+      props: {
+        key: String,
+        ref: String,
+        $foo: String,
+      },
+      render() {},
+    })
+
+    const root = nodeOps.createElement('div')
+
+    render(h(Comp, { msg: 'test' }), root)
+
+    expect(`Invalid prop name: "key"`).toHaveBeenWarned()
+    expect(`Invalid prop name: "ref"`).toHaveBeenWarned()
+    expect(`Invalid prop name: "$foo"`).toHaveBeenWarned()
+  })
 })

+ 1 - 1
packages/runtime-core/src/componentProps.ts

@@ -586,7 +586,7 @@ export function normalizePropsOptions(
 }
 
 function validatePropName(key: string) {
-  if (key[0] !== '$') {
+  if (key[0] !== '$' && !isReservedProp(key)) {
     return true
   } else if (__DEV__) {
     warn(`Invalid prop name: "${key}" is a reserved property.`)