Преглед на файлове

fix(keep-alive): should remove wrapped version of injected keep alive hooks (#1959)

zhangzhonghe преди 5 години
родител
ревизия
1ea24000c8
променени са 2 файла, в които са добавени 7 реда и са изтрити 4 реда
  1. 2 1
      packages/runtime-core/src/apiLifecycle.ts
  2. 5 3
      packages/runtime-core/src/components/KeepAlive.ts

+ 2 - 1
packages/runtime-core/src/apiLifecycle.ts

@@ -18,7 +18,7 @@ export function injectHook(
   hook: Function & { __weh?: Function },
   target: ComponentInternalInstance | null = currentInstance,
   prepend: boolean = false
-) {
+): Function | undefined {
   if (target) {
     const hooks = target[type] || (target[type] = [])
     // cache the error handling wrapper for injected hooks so the same hook
@@ -47,6 +47,7 @@ export function injectHook(
     } else {
       hooks.push(wrappedHook)
     }
+    return wrappedHook
   } else if (__DEV__) {
     const apiName = `on${capitalize(
       ErrorTypeStrings[type].replace(/ hook$/, '')

+ 5 - 3
packages/runtime-core/src/components/KeepAlive.ts

@@ -360,14 +360,16 @@ function registerKeepAliveHook(
 }
 
 function injectToKeepAliveRoot(
-  hook: Function,
+  hook: Function & { __weh?: Function },
   type: LifecycleHooks,
   target: ComponentInternalInstance,
   keepAliveRoot: ComponentInternalInstance
 ) {
-  injectHook(type, hook, keepAliveRoot, true /* prepend */)
+  // injectHook wraps the original for error handling, so make sure to remove
+  // the wrapped version.
+  const injected = injectHook(type, hook, keepAliveRoot, true /* prepend */)
   onUnmounted(() => {
-    remove(keepAliveRoot[type]!, hook)
+    remove(keepAliveRoot[type]!, injected)
   }, target)
 }